Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

interface-ipfs-core tests failing on my machine #902

Closed
kumavis opened this issue Jul 7, 2017 · 5 comments
Closed

interface-ipfs-core tests failing on my machine #902

kumavis opened this issue Jul 7, 2017 · 5 comments
Labels
kind/bug A bug in existing code (including security flaws) P4 Very low priority status/deferred Conscious decision to pause or backlog

Comments

@kumavis
Copy link
Contributor

kumavis commented Jul 7, 2017

on a fresh clone of master

  52 passing (3m)
  2 pending
  3 failing

  1) interface-ipfs-core tests .files callback API .add BIG buffer:
     Error: Uncaught AssertionError: expected [] to have a length of 1 but got 0 (webpack:///~/chai/lib/chai/assertion.js?fee1:141:0 <- test/core/interface/interface.spec.js:152161)

  

  2) interface-ipfs-core tests .files callback API .add .createAddStream stream of valid files and dirs:
     Error: Uncaught AssertionError: expected 'QmZf3drqiuCuuCZKSmvhVRV6GH4QuJj7Gwy1QEacRMKLfy' to equal 'QmVvjDy7yF7hdnqE8Hrf4MHo5ABDtb5AbX6hWbD3Y42bXP' (webpack:///~/chai/lib/chai/assertion.js?fee1:141:0 <- test/core/interface/interface.spec.js:152161)

  

  3) interface-ipfs-core tests .files callback API .cat streams a large file:
     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
@kumavis
Copy link
Contributor Author

kumavis commented Jul 7, 2017

my system setup is a bit nonstandard
im running qubes (which forwards traffic through a few vms) and have a vpn
not sure if this will affect it

@daviddias
Copy link
Member

It's hard for me to see what's going on without having a way to replicate the environment.

The files API should not fail and since WebRTC is not injected by default anymore, there shouldn't be anything that could cause a lag on the network side of things that would trickle lagging to those tests.

The first two tests seem like a Race condition to me (//cc @pgte) and the third one fails because the other two didn't finish correctly.

@daviddias daviddias added kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog labels Jul 9, 2017
@pgte
Copy link
Contributor

pgte commented Jul 10, 2017

@kumavis can't seam to reproduce this in any way...
Is this failure consistent?

@kumavis
Copy link
Contributor Author

kumavis commented Jul 13, 2017

yeah consistent on re-runs

user@work  ~/dev/js-ipfs   master 
 ⧖  npm -v
4.6.1

 user@work  ~/dev/js-ipfs   master 
 ⧖  node -v
v8.1.3

just pull down latest (after 0.25 release) and got a new error added to the set

  123 passing (3m)
  8 pending
  4 failing

  1) interface-ipfs-core tests .files callback API .add BIG buffer:
     Error: Uncaught AssertionError: expected [] to have a length of 1 but got 0 (webpack:///~/chai/lib/chai/assertion.js?fee1:141:0 <- test/core/interface/interface.spec.js:123057)

  

  2) interface-ipfs-core tests .files callback API .add .createAddStream stream of valid files and dirs:
     Error: Uncaught AssertionError: expected 'QmZf3drqiuCuuCZKSmvhVRV6GH4QuJj7Gwy1QEacRMKLfy' to equal 'QmVvjDy7yF7hdnqE8Hrf4MHo5ABDtb5AbX6hWbD3Y42bXP' (webpack:///~/chai/lib/chai/assertion.js?fee1:141:0 <- test/core/interface/interface.spec.js:123057)

  

  3) interface-ipfs-core tests .files callback API .cat streams a large file:
     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

  

  4) interface-ipfs-core tests .files callback API .get large file:
     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

these failures are all on 'test:karma-raw'

so maybe some issue with browser comms?

@daviddias daviddias added the P4 Very low priority label Jul 26, 2017
@daviddias
Copy link
Member

@kumavis closing this one. If you manage to replicate this issue for us, I'm happy to reopen and tackle it :)

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this issue May 22, 2020
Allows users to access these additional types and utilities without having to create an instance of the client first.

resolves ipfs#902

BREAKING CHANGE: `ipfs.util.isIPFS` has moved to a static export and should be accessed via `const { isIPFS } = require('ipfs-http-client')`.

The modules available under `ipfs.types.*` have also become static exports.

`ipfs.util.crypto` has been removed as it is not a dependency of `ipfs-http-client` so reduces the bundle size. If you need to use libp2p crypto primitives then please see the [js-libp2p-crypto](https://github.com/libp2p/js-libp2p-crypto) project for info on how to use it in your project.

Finally `ipfs.util.getEndpointConfig` is now a direct instance method, `ipfs.getEndpointConfig`

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws) P4 Very low priority status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

No branches or pull requests

3 participants