This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: support specify hash algorithm in files.add #1005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
previously approved these changes
Sep 8, 2017
daviddias
suggested changes
Sep 8, 2017
src/core/components/object.js
Outdated
| @@ -178,20 +164,19 @@ module.exports = function object (self) { | |||
| } | |||
| }), | |||
|
|
|||
| get: promisify((multihash, options, callback) => { | |||
| get: promisify((hash, options, callback) => { | |||
There was a problem hiding this comment.
same nitpick as js-ipfs-api, they follow the same interface :)
daviddias
approved these changes
Sep 8, 2017
|
@alanshaw do the tests fail to you locally as well? |
|
Yes these have failed for me too :( I'll take a look asap. |
|
@alanshaw this needs a rebase from master (things just moved around) |
daviddias
added a commit
that referenced
this pull request
Sep 8, 2017
* wip - incomplete feature -> #1005 * fix: swarm.peers - ensure that only peers connected are returned
dryajov
pushed a commit
that referenced
this pull request
Sep 12, 2017
* wip - incomplete feature -> #1005 * fix: swarm.peers - ensure that only peers connected are returned
|
@alanshaw are you available to finish this PR? |
daviddias
added
exp/expert
daviddias
changed the title
|
@hacdias wanna look into this one? |
vasco-santos
added
status/in-progress
vasco-santos
added
status/ready
|
Done on #1308 |
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify multihash hashing alogrithm
This allows the optional param
--hash(CLI) or?hash=(HTTP API) to be passed tofiles.addin order to specify the hash algorithm that should be used when generating the multihash(es) for the added content.Passing this option will set the CID version option to
true, as per the Go implementation.Change
object/getandobject/datato accept CIDsThis brings js-ipfs more in line with go-ipfs. Where both
object/getandobject/dataaccept a CID. It's also needed byjs-ipfs-apiwhen adding files (see further discussion in ipfs-inactive/js-ipfs-http-client#597).requires ipfs-inactive/js-ipfs-unixfs-engine#185requires ipfs-inactive/js-ipfs-http-client#597