Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

FAQ: add custom signaling server description #1104

Merged
merged 1 commit into from
Nov 22, 2017
Merged

FAQ: add custom signaling server description #1104

merged 1 commit into from
Nov 22, 2017

Conversation

AquiGorka
Copy link
Member

@diasdavid as requested.

@AquiGorka
FAQ: add custom signaling server description
e84bbb5 
License: MIT
Signed-off-by: Jorge Ludlow <gorka@aquigorka.com>
daviddias
daviddias approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AquiGorka :)

@daviddias daviddias merged commit 0258759 into ipfs:master Nov 22, 2017
@ghost
Copy link

ghost commented Nov 22, 2017

Hold on, are you sure you need pubsub for this? That'd seem odd to me.

@AquiGorka
Copy link
Member Author

AquiGorka commented Nov 22, 2017 •
edited
Loading

You are right. pubsub is not needed to use a custom signaling server. The way I phrased the description it implies so - I needed my own signaling server for pubsub but it is orthogonal in this case. I'll send a new PR tomorrow.

This was referenced Jan 26, 2022
Open
Open
Open
This was referenced Mar 21, 2022
Open
Open
Open
@rtpro rtpro mentioned this pull request Jan 10, 2023
Open
@internetbuilder internetbuilder mentioned this pull request Nov 29, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AquiGorka @daviddias