fix SIG tests #1105
fix SIG tests #1105
Conversation
ghost
assigned 
| it.skip('should handle SIGTERM gracefully', function (done) { | ||
| this.timeout(20 * 1000) | ||
| it('should handle SIGTERM gracefully', function (done) { | ||
| this.timeout(100 * 1000) |
There was a problem hiding this comment.
Why does this take so much time?
There was a problem hiding this comment.
It needs to start and init the repo for the IPFS node each time, which seems to be slow.
There was a problem hiding this comment.
The other tests take 40s or less, why 100s in this one?
There was a problem hiding this comment.
I wasn't able to get it to work with anything below 60 on my box, 100 seems to be the most stable.
I'm guessing that it is because it has to:
- start the daemon
- init the repo
- send the signal and wait for daemon to clean up and exit
The 40 (in i.e. block tests)
Line 15 in ac95601
js-ipfs/test/utils/on-and-off.js
Line 20 in 104ef1e
before hook that gets the daemon started and initialized.
So I think it currently is more like 70 + ~30 for graceful shutdown. I think we can tweak the 30 a little bit.
|
Please rebase master onto this branch |
dryajov
force-pushed
the
fix/daemon-tests
branch
from
2ffa5f5 to
60631ce
Compare
|
done rebasing. |
|
Some tests are failing but not due to this PR. |
temp fix for electron renderer until ky-universal is fixed Blob can accept Buffer directly Buffer.buffer triggered a super weird bug in electron renderer enable a bunch of tests in the browser xvfb-run makes electron go crazy detect-node needs to be removed everywhere and ipfs-utils/src/env.js should be used If you mix promises and callbacks inside, call the callback with setImmediate
Tests are failing due to timeouts. These tests are awfully slow, we might want to consider skipping them on normal runs?