Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[WIP] Improve Transfer Files Example #1140

Merged
merged 23 commits into from
Dec 13, 2017
Merged

[WIP] Improve Transfer Files Example #1140

merged 23 commits into from
Dec 13, 2017

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Dec 9, 2017

No description provided.

@ghost ghost assigned hacdias Dec 9, 2017
@ghost ghost added the status/in-progress In progress label Dec 9, 2017
@codecov
Copy link

codecov bot commented Dec 9, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@a137002). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1140   +/-   ##
=========================================
  Coverage          ?   83.39%           
=========================================
  Files             ?      122           
  Lines             ?     2734           
  Branches          ?        0           
=========================================
  Hits              ?     2280           
  Misses            ?      454           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a137002...1cf56c6. Read the comment docs.

@daviddias
Copy link
Member

Screeenshot :D

@hacdias
Copy link
Member Author

hacdias commented Dec 9, 2017

Haven't changed the design much. Just simplified the CSS and JS. Any suggestions? I think we should be able to toggle the peers.

image

image

@hacdias
Copy link
Member Author

hacdias commented Dec 9, 2017

Just tweaked the header

image

@daviddias
Copy link
Member

@hacdias here you go:

image

@hacdias
Copy link
Member Author

hacdias commented Dec 9, 2017 via email

@hacdias
Copy link
Member Author

hacdias commented Dec 10, 2017

@diasdavid look at this 😄

127 0 0 1_12345_ 1
127 0 0 1_12345_ 2
127 0 0 1_12345_ 3

@hacdias
Copy link
Member Author

hacdias commented Dec 10, 2017

getting this error:

image

When using IPFS from //unpkg.com/ipfs/dist/index.min.js. If I use //unpkg.com/ipfs/dist/index.js, it works flawlessly.

@daviddias
Copy link
Member

@hacdias see #1131. Wanna take the lead at fixing the issue in the aegir's Webpack config?

@daviddias
Copy link
Member

daviddias commented Dec 10, 2017

Awesome work @hacdias, almost there!

Here is some more feedback :)

image

@daviddias
Copy link
Member

Also, I liked this variation:

image

Perhaps do IPFS | InterPlanetary File Exchange

@hacdias
Copy link
Member Author

hacdias commented Dec 10, 2017

localhost_12345_

@hacdias
Copy link
Member Author

hacdias commented Dec 12, 2017

127 0 0 1_12345_

I haven't added the 'Name' field because of this:

image

I can't get the real name of the file for some strange reason.

@hacdias
Copy link
Member Author

hacdias commented Dec 13, 2017

localhost_2015_

I think it's done for now 😄 What do you think @diasdavid? (when you click the table row, it downloads the file)

@daviddias
Copy link
Member

@hacdias Looking good! One last small request. Can you make a better use of the screen size? In my 15" it looks like:

image

It is a shame to be breaking lines when the columns could just be wider

@daviddias
Copy link
Member

🐞 Ah, just noticed that there is no way to download the files anymore.

@hacdias
Copy link
Member Author

hacdias commented Dec 13, 2017

Check it now please 😄

@daviddias
Copy link
Member

Wooot! it is working now. Thank you @hacdias :D

@daviddias daviddias merged commit f66aac8 into master Dec 13, 2017
@ghost ghost removed the status/in-progress In progress label Dec 13, 2017
@daviddias daviddias deleted the improve-example branch December 13, 2017 09:12
@hacdias
Copy link
Member Author

hacdias commented Dec 13, 2017

😀😃😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants