Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix(files.add): directory with odd name #1155

Merged
merged 1 commit into from
Dec 18, 2017
Merged

fix(files.add): directory with odd name #1155

merged 1 commit into from
Dec 18, 2017

Conversation

richardschneider
Copy link
Contributor

@richardschneider richardschneider commented Dec 18, 2017

glob was interpreting the '[' as a special magic character. According to its documentation, a caller should be able to escape it with \; but it does not work.

See the glob issue.

@ghost ghost added the status/in-progress In progress label Dec 18, 2017
@richardschneider
Copy link
Contributor Author

@diasdavid typical browser failure on other tests on travis. Circle CI passes everything.

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @richardschneider :)

@daviddias daviddias merged commit 058c674 into master Dec 18, 2017
@daviddias daviddias deleted the dirname-2 branch December 18, 2017 07:49
@ghost ghost removed the status/in-progress In progress label Dec 18, 2017
@richardschneider
Copy link
Contributor Author

@diasdavid can you send me the git commands for git rebasing a branch.

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
BREAKING CHANGE: Errors returned from request failures are now all [`HTTPError`](https://github.com/sindresorhus/ky/blob/c0d9d2bb07e4c122a08f019b39e9c55a4c9324f3/index.js#L117-L123)s which carry a `response` property. This is a [`Response`](https://developer.mozilla.org/en-US/docs/Web/API/Response) that can be used to inspect _all_ information relating to the HTTP response. This means that the `err.status` or `err.statusCode` property should now be accessed via `err.response.status`.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants