This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: Adds tests for programmatic pubsub #1217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a larger batch of tests coming from our interface-ipfs-core repo. They get loaded here -- https://github.com/ipfs/js-ipfs/blob/master/test/core/interface/pubsub.js -- and they are run against js-ipfs and js-ipfs-api to ensure that both have the same interface. Could you diff your tests to that batch and add the ones that are different to that set? This way we are sure that both implementations comply. Thanks @achingbrain :) |
daviddias
suggested changes
Feb 15, 2018
| it('should subscribe without options', (done) => { | ||
| const handler = (event) => { | ||
| expect(event.data.toString('utf8')).to.equal(message) | ||
| done() |
There was a problem hiding this comment.
Should unsubscribe before done to avoid side effects.
|
Ah, nice. I think the invocation I wanted to test is covered here so this PR is sort of redundant. |
|
@achingbrain do you confirm that #1129 is solved then? |
|
Yes, I think that issue should be closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #1129.
There were no tests that invoked the subscribe method with only two arguments so I added some. I also added tests for other pubsub methods.
I found some existing pubsub tests but these go via the CLI and from what I can see the subscribe/publish test only uses one node.
Happy to make whatever changes are required, please let me know if anything needs changing to be more idiomatic for the project or if you'd like them added to the existing cli pubsub test suite instead.