This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: make pubsub.unsubscribe async and alter pubsub.subscribe signature #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Just a headup, the commit should contain "Breaking change" somewhere Edit: somewhere being the footer of commit message |
BREAKING CHANGE: pubsub.unsubscribe is now async and argument order for pubsub.subscribe has changed License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw
force-pushed
the
fix/pubsub-unsub-async
branch
from
6373c0d
to
7ca8025
Compare
alanshaw
changed the title
daviddias
suggested changes
May 11, 2018
src/core/components/pubsub.js
Outdated
| return Promise.resolve() | ||
| } | ||
|
|
||
| process.nextTick(() => callback()) |
There was a problem hiding this comment.
not all bundlers know how to handle process.nextTick well. We always use async/setImmediate for that matter.
BREAKING CHANGE: pubsub.unsubscribe is now async and argument order for pubsub.subscribe has changed License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
daviddias
force-pushed
the
fix/pubsub-unsub-async
branch
from
fae1927
to
bb5e3ab
Compare
… fix/pubsub-unsub-async
|
@diasdavid tests not passing here because |
|
@diasdavid pubsub tests now pass for me when I npm link |
|
@alanshaw ipfsd-ctl 0.34 is out :) |
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
daviddias
approved these changes
May 14, 2018
|
🎉 only unrelated DNS test failed... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on ipfs-inactive/interface-js-ipfs-core#260 and ipfs-inactive/js-ipfs-http-client#760