Node 10 #1369
Node 10 #1369
Conversation
ghost
assigned
| @@ -110,7 +110,7 @@ | |||
| "ipfs-block": "~0.7.1", | |||
| "ipfs-block-service": "~0.14.0", | |||
| "ipfs-multipart": "~0.1.0", | |||
| "ipfs-repo": "~0.20.0", | |||
| "ipfs-repo": "~0.22.0", | |||
There was a problem hiding this comment.
@jacobheun CI is not happy with the latest ipfs-repo. How did you run the tests before (ref: ipfs/js-ipfs-repo#168 (comment))
There was a problem hiding this comment.
This is due to the ipld PR, ipld/js-ipld#129, that needs released. I will update #1358 once that is done.
The current versioning scheme results in old leveldown being installed for ipld, which breaks the install.
There was a problem hiding this comment.
There was a problem hiding this comment.
@diasdavid I already have a PR open for node 10 that is running tests now, #1358. It also includes the fix for the breaking change in ipfs-repo 0.20.1 ipfs/js-ipfs-repo#165, which is the errors your PR is getting.
There was a problem hiding this comment.
Missed that one. I had read from your message that you had tested against js-ipfs master. All good then :)
Let's give Node 10 a spin! :)