This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: allow put empty block & add X-Stream-Output header on get #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows the test in ipfs-inactive/interface-js-ipfs-core#308 to pass. X-Stream-Output header is added to block.get reply for parity with go-ipfs. block.put is altered to allow an empty block to be put (again for fetaure parity with go-ipfs) but only if there is a multipart file part for it. Error responses have also been improved. refs ipfs-inactive/js-ipfs-http-client#789 tested by ipfs-inactive/interface-js-ipfs-core#308 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw
changed the title
daviddias
approved these changes
Jun 26, 2018
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the test in ipfs-inactive/interface-js-ipfs-core#308 to pass.
X-Stream-Outputheader is added to theblock.getreply for parity with go-ipfs.block.putis altered to allow an empty block to be put (again for feature parity with go-ipfs) but only if there is a multipart file part for it. Error responses have also been improved.depends on ipfs-inactive/js-ipfs-http-client#789
tested by ipfs-inactive/interface-js-ipfs-core#308