This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
test(dag): skip spec for put API #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind of only makes sense to merge after ipfs-inactive/interface-js-ipfs-core#323 has landed. |
|
Not sure if CI is flaky or if there's really a problem with this change on windows machines. To me it looks like failing CI is unrelated to this PR's changes. |
alanshaw
suggested changes
Jul 5, 2018
test/core/interface.spec.js
Outdated
| skip: [ | ||
| { | ||
| name: 'should override hash algoritm default and resolve with it', | ||
| reason: 'ipld/js-ipld/pull/133 needs to land first' |
There was a problem hiding this comment.
Could you please add the full URL here? CI actually turns these into clickable links e.g.
Looks unrelated, I'm re-running the tests to double check. |
Over at ipfs-inactive/interface-js-ipfs-core#323 we introduce a test spec that ensures `dag.put()` honors the `hashAlg` option, which at the time of this commit is ignored by the underlying `ipld.put()` API (more info: ipfs@1a36375). This commit skips that spec in `js-ipfs` as ipld/js-ipld#133 has to land first to fulfill the scenario. License: MIT Signed-off-by: Pascal Precht <pascal.precht@gmail.com>
alanshaw
approved these changes
Jul 5, 2018
This was referenced Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at ipfs-inactive/interface-js-ipfs-core#323 we introduce a
test spec that ensures
dag.put()honors thehashAlgoption, which atthe time of this commit is ignored by the underlying
ipld.put()API(more info: 1a36375).
This commit skips that spec in
js-ipfsas ipld/js-ipld#133 has toland first to fulfill the scenario.
License: MIT
Signed-off-by: Pascal Precht pascal.precht@gmail.com