This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned alanshaw
Jul 27, 2018
@alanshaw @diasdavid Getting this in would release the fix for the "already piped" errors, that you get when you leave a js-ipfs node running for a while. https://github.com/libp2p/js-libp2p-switch/issues/235 There are 28 days of other libp2p updates behind that version increment, so we'd need to run all the third party app tests again to feel confident there are no surprises, but you know, ONLY FORWARDS! cc @jacobheun |
daviddias
approved these changes
Jul 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take in consideration @olizilla's comment, but fixing the already piped errors does sound really great to me!
This one keeps appearing.
|
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
daviddias
force-pushed
the
chore/update-deps-20180727
branch
from
July 28, 2018 07:21
da5e92d
to
397eab3
Compare
ghost
assigned daviddias
Jul 28, 2018
alanshaw
changed the title
chore: update libp2p and is-ipfs dependencies
chore: update dependencies
Jul 28, 2018
Only test failing now is related with preload
|
alanshaw
added a commit
that referenced
this pull request
Jul 29, 2018
When JS IPFS requests content not stored locally it needs to ask the peers it knows about to provide it if they have it. The peers are not relays so if they don't have it, they won't find it and provide it to JS IPFS. However, if we issue a preload request prior to these requests we prompt the preload nodes to fetch the content using their DHT and they can then provide it to JS IPFS. License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io> * chore: update dependencies (#1473) * chore: update libp2p and is-ipfs dependencies License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io> * chore: update all the deps * fix: rm non used boostrappers from tests * test: increase mfs preload timeout * test: pin-set timeout increase * test: add preload tests for content retrieval License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io> * fix: GET request not HEAD License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.