This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix(dag): check dag.put options for plain object #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
reviewed
Jul 30, 2018
src/core/components/dag.js
Outdated
| } else if ((options.format && !options.hashAlg) || (!options.format && options.hashAlg)) { | ||
| return callback(new Error('Can\'t put dag node. Please provide `format` AND `hashAlg` options.')) | ||
| options = {} | ||
| } else if (isPlainObject(options)) { |
There was a problem hiding this comment.
How about instead of introduce isPlainObject() we'd just introduce a check on whether options is defined:
if (options && options.cid && (options.format || options.hasAlg)) {
...
} else if (/* same thing here */)
And then we'd remove the else block and always do sth. like options = options || {}
|
This LGTM but there seems to be a hiccup with CI.. maybe someone with privilege can restart the job to see if that fixes it? |
ghost
assigned 
|
Thanks @negamaxi ✨ . I have rebased this. Fixes to failing and temperamental tests have been merged to master so lets see what CI says now :D |
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
This was referenced Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1479