-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
I'm getting a bit lost trying to investigate the build failures. The OSX tests are failing for a timeout. Master seems to be built using CIrcleCI and the PR by jenkins, both seem to have been failing for a while now (going by red crosses next to all first page of commits on master and all first page of open pull requests). Should I be concerned about this? If so, could someone give me a pointer please? |
While playing around with IPFS using Parcel.js I came across a problem with babel-preset-env transpiling too aggressively and breaking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 ❤️ thank you! The code LGTM, just a couple of minor tweaks and this should be good to merge!
I've made the requested changes. I haven't rebased the pull request off master and this PR is now behind, should I rebase @alanshaw? |
The commitlint check is failing because I accidentally missed the 's' off docs on this commit I'll have to rebase to fix this unless you plan to squash the commits when merging. Sorry, I'm still getting to grips of the protocol you follow so I've been cautious and left it as-is. |
26f5a44
to
99e5a58
Compare
The force push is changing the README image to match the code on the tip of this PR |
99e5a58
to
381b35d
Compare
Fastly is caching the README image, it will be in sync with the code when the cache expires |
Changes look great. I'll give it a spin tomorrow morning and if it all works we can merge - thanks again! |
This is an example of developing and building a Dapp which connects to IPFS that is bundled by Parcel.js: one of the desired examples in #1436
A version served over IPFS can be found here (for the commit that opens this PR)
Notes and known limitations
add
ing andcat
ing are using the newer root API calls.Please be gentle this is my first non-typo IPFS contribution, I look forward to any feedback. :)