This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: add from fs #1777
Merged
feat: add from fs #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
force-pushed
the
feat/add-from-fs
branch
from
a1b56d5
to
fa9158e
Compare
alanshaw
force-pushed
the
feat/add-from-fs
branch
from
fa9158e
to
200e4fb
Compare
achingbrain
reviewed
Dec 13, 2018
hugomrdias
suggested changes
Dec 13, 2018
| const Path = require('path') | ||
| const isString = require('lodash/isString') | ||
| const pull = require('pull-stream') | ||
| const glob = require('glob') |
There was a problem hiding this comment.
can't we just use https://www.npmjs.com/package/fast-glob ? it's faster and supports streams so we can go directly to pull-stream
There was a problem hiding this comment.
I tried it, and it's not significantly faster than glob, in fact in most tests it's slower (left is glob, right is fast-glob).
There was a problem hiding this comment.
even using streams instead of glob events ? seems weird but if its faster like this im good with it
There was a problem hiding this comment.
I know weird, maybe it is the stream to pull stream conversion? Anyway even weirder is that the benchmarks for fast-glob do not run against glob 😱 They benchmark globby, bash-glob, tiny-glob and glob-stream...but not regular glob 🙄.
There was a problem hiding this comment.
lol that kinda wtf and globby is based on fast-glob with some sindre sugar on top
anyway this looks fine and if your benchs show better numbers lets merge it
alanshaw
force-pushed
the
feat/add-from-fs
branch
from
ca34d52
to
e24fc37
Compare
added 7 commits
December 17, 2018 10:30
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
This PR adds a new method [`addFromFs`](https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/FILES.md#addfromfs) allowing users to more easily add files from their file system without having to specify every single file to add. In the browser the user will receive a "not available" error. I've pulled out a module `glob-source.js` - call it with some file paths and it returns a pull stream source that can be piped to `ipfs.addPullStream`. This PR comes with the following added benefits: * `ipfs add` on the CLI uses `glob-source.js` - **nice and DRY** * `glob-source.js` uses the events that the `glob` module provides allowing the globbing to be a `pull-pushable`, which means that matched paths can begin to be added before all the globbing is done - **faster** * `ipfs add` now supports adding multiple paths, fixes #1625 - **better** * `ipfs add --progress=false` doesn't calculate the total size of the files to be added anymore! It didn't need to do that as the total was completely discarded when progress was disabled. It means we can add BIGGER directories without running into memory issues - **stronger** License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
feat/add-from-fs
branch
from
5d486a0
to
158d37d
Compare
added 2 commits
December 17, 2018 12:33
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
@hugomrdias is this gtg now? |
hugomrdias
approved these changes
Dec 18, 2018
achingbrain
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
addFromFsallowing users to more easily add files from their file system without having to specify every single file to add.In the browser the user will receive a "not available" error.
I've pulled out a module
glob-source.js- call it with some file paths and it returns a pull stream source that can be piped toipfs.addPullStream.This PR comes with the following added benefits:
ipfs addon the CLI usesglob-source.js- nice and DRYglob-source.jsuses the events that theglobmodule provides allowing the globbing to be apull-pushable, which means that matched paths can begin to be added before all the globbing is done - fasteripfs addnow supports adding multiple paths, fixes Cannot add multiple files from command line #1625 - betteripfs add --progress=falsedoesn't calculate the total size of the files to be added anymore! It didn't need to do that as the total was completely discarded when progress was disabled. It means we can add BIGGER directories without running into memory issues - stronger