This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: adds http DAG api #1930
Merged
feat: adds http DAG api #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
achingbrain
force-pushed
the
add-http-dag-api
branch
3 times, most recently
from
946f455 to
6111234
Compare
alanshaw
suggested changes
Mar 14, 2019
src/http/api/resources/dag.js
Outdated
|
|
||
| if (key.codec === 'dag-pb' && result.value) { | ||
| if (typeof result.value.toJSON === 'function') { | ||
| result.value = result.value.toJSON() |
Member
There was a problem hiding this comment.
Just wondering if this is required? JSON.stringify will call this automatically...which is what I assume happens after you pass this to h.response 😝.
I also assume that because we're not setting the Content-Type header explicitly that Hapi will infer text/plain from the string you create here and pass to h.response, instead of application/json (which is what we want).
Member
Author
There was a problem hiding this comment.
According to the HTTP API docs /dag/get should return a text/plain response body, which seems like an odd decision.
achingbrain
force-pushed
the
add-http-dag-api
branch
from
a499fc9 to
976e955
Compare
alanshaw
approved these changes
Mar 15, 2019
Member
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
Code LGTM, just waiting for CI 👍
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
add-http-dag-api
branch
from
98414f1 to
ec3b44f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.