Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat(bitswap humanize): add humanize flag (--human) support to bitswap stat #2150

Closed

Conversation

Prabhakar-Poudel
Copy link
Contributor

@Prabhakar-Poudel Prabhakar-Poudel commented Jun 1, 2019

  • add humanize option (--human) to bitswap stat cli command
    jsipfs bitswap stat --human
    OR
    jsipfs stats bitswap --human

  • add related test for the same

closes: #2057

License: MIT
Signed-off-by: Prabhakar-Poudel yuvrajzohan@gmail.com

add humanize option (--human) to bitswap stat cli command
add related test for the same

closes: ipfs#2057

License: MIT
Signed-off-by: Prabhakar-Poudel <yuvrajzohan@gmail.com>
@Prabhakar-Poudel
Copy link
Contributor Author

@alanshaw
Wanted to add more specific tests. Currently only the dup data received result is in Bytes.
Not sure how do I add dup data to make tests more meaningful/correct.

@daviddias
Copy link
Member

@Prabhakar-Poudel There are several merge conflicts at the moment. Mind rebasing master onto this branch?

@daviddias
Copy link
Member

Wanted to add more specific tests. Currently only the dup data received result is in Bytes.
Not sure how do I add dup data to make tests more meaningful/correct.

You would need to fetch a file that exists in multiple other nodes.

@tinytb
Copy link

tinytb commented Feb 2, 2023

fixed by #2619

@tinytb tinytb closed this Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ipfs bitswap stat --human
3 participants