-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: integrate ipfs-repo-migrations tool #2527
Conversation
d285a12
to
5b8562d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we haz a test here as well (will be similar to js-ipfs-repo).
@daviddias should it be part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about --migrate
option to ipfs daemon
like go-ipfs?
Hmmm that is a good point, but Is that alright? |
Gotcha, yes that makes perfect sense. |
Although, how it should behave? I believe that Currently, here the migrations are automatically run because of browsers, so should that be |
@alanshaw ping ^ |
I just meant we can leave it for now. |
5b8562d
to
78b64e6
Compare
@AuHau and I spoke about this in IRC and decided to default to |
3271102
to
825a58c
Compare
So it is ready for review. Unfortunately, I did not manage to add any tests. I am now pressed to put time somewhere else, so I don't think I will be able to work on tests anytime soon if they will be needed... |
No worries, I'll pick this up from here - thanks for all your work on this @AuHau ❤️ |
8c842c2
to
6a5fbc8
Compare
Resolves: #1115
Supersedes: #2044
Depends on: