This repository was archived by the owner on Feb 12, 2024. It is now read-only.
docs: update package table on README #2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
reviewed
Nov 12, 2019
| | [`ipfs-mfs`](//github.com/ipfs/js-ipfs-mfs) | [](//github.com/ipfs/js-ipfs-mfs/releases) | [](https://david-dm.org/ipfs/js-ipfs-mfs) | [](https://travis-ci.com/ipfs/js-ipfs-mfs) | [](https://codecov.io/gh/ipfs/js-ipfs-mfs) | [Alex Potsides](mailto:alex.potsides@protocol.ai) | | ||
| | [`ipfs-unixfs`](//github.com/ipfs/js-ipfs-unixfs) | [](//github.com/ipfs/js-ipfs-unixfs/releases) | [](https://david-dm.org/ipfs/js-ipfs-unixfs) | [](https://travis-ci.com/ipfs/js-ipfs-unixfs) | [](https://codecov.io/gh/ipfs/js-ipfs-unixfs) | [Alex Potsides](mailto:alex.potsides@protocol.ai) | | ||
| | [`ipfs-unixfs-exporter`](//github.com/ipfs/js-ipfs-unixfs-exporter) | [](//github.com/ipfs/js-ipfs-unixfs-exporter/releases) | [](https://david-dm.org/ipfs/js-ipfs-unixfs-exporter) | [](https://travis-ci.com/ipfs/js-ipfs-unixfs-exporter) | [](https://codecov.io/gh/ipfs/js-ipfs-unixfs-exporter) | [Alex Potsides](mailto:alex.potsides@protocol.ai) | | ||
| | [`ipfs-unixfs-importer`](//github.com/ipfs/js-ipfs-unixfs-importer) | [](//github.com/ipfs/js-ipfs-unixfs-importer/releases) | [](https://david-dm.org/ipfs/js-ipfs-unixfs-importer) | [](https://travis-ci.com/ipfs/js-ipfs-unixfs-importer) | [](https://codecov.io/gh/ipfs/js-ipfs-unixfs-importer) | [Alex Potsides](mailto:alex.potsides@protocol.ai) | |
There was a problem hiding this comment.
As part of this update, wanna move the 2 lines that js-ipfs-unixfs-engine does to js-ipfs itself? ipfs-inactive/js-ipfs-unixfs-engine#237 (comment)
There was a problem hiding this comment.
Not sure I understand? It doesn’t use the engine (and hasn’t for a long while) and already requires them separately.
There was a problem hiding this comment.
Gotcha! https://github.com/ipfs/js-ipfs/blob/master/package.json#L108-L110
Then https://github.com/ipfs/js-ipfs-unixfs-engine should be deprecated, no? It will break with the async refactor anyway.
There was a problem hiding this comment.
👍 I'll open an issue. As I mentioned in the PR description it's out of date (depends on old versions of importer/exporter) so I'm sure this will be fine.
There was a problem hiding this comment.
|
Is a good PR tho? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
unixfs-engine(is out of date and just a shell that requires importer & exporter) and addslibp2p-gossipsub.