Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

refactor: convert dag API to async/await #2664

Merged
merged 2 commits into from
Dec 16, 2019
Merged

refactor: convert dag API to async/await #2664

merged 2 commits into from
Dec 16, 2019

Conversation

alanshaw
Copy link
Member

⚠️ Note: this will be merged into #2660 since it depends on the pin API.

In the future we might need a DAGService like go-ipfs to break the circular dependency.

TODO: fix in ipfs-http-client ipfs-inactive/js-ipfs-http-client#1183 - BREAKING CHANGE: dag.resolve and dag.tree now return an async iterable

@alanshaw alanshaw mentioned this pull request Dec 11, 2019
Closed
@alanshaw alanshaw requested a review from dirkmc December 13, 2019 17:31
dirkmc
dirkmc approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise LGTM 👍

src/core/components/dag/put.js Show resolved Hide resolved
@alanshaw alanshaw merged commit a482044 into refactor/block-and-pin-async-await Dec 16, 2019
@alanshaw alanshaw deleted the refactor/dag-async-await branch December 16, 2019 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirkmc dirkmc dirkmc approved these changes

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @dirkmc