This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: await on things that need awaiting on #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are async methods and can result in unhandledPromiseRejection events :(
hugomrdias
approved these changes
Feb 12, 2020
|
I think this has broken the libp2p example. |
alanshaw
approved these changes
Feb 12, 2020
|
Wot, more breaking changes in a patch release? |
|
I'm going to merge this and fix up the custom libp2p example in a subsequent PR. |
achingbrain
deleted the
refactor/await-on-things-that-need-awaiting-on
branch
alanshaw
pushed a commit
that referenced
this pull request
Feb 13, 2020
These are async methods and can result in unhandledPromiseRejection events :(
This was referenced Mar 12, 2020
This was referenced May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are async methods and can result in unhandledPromiseRejection events :(