Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: sync with go-ipfs 0.5 #3013

Merged
merged 30 commits into from
Jun 4, 2020
Merged

feat: sync with go-ipfs 0.5 #3013

merged 30 commits into from
Jun 4, 2020

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Apr 29, 2020

  • ipfs.ls remove all options in core api, but keep long in http api and cli same as go-ipfs
    • remove sort from the cli and ignore go-ipfs U option
    • enable http api mfs tests
  • key.gen defaults, to rsa and 2048
  • pin.list no need to support non stream responses
  • understand the U args in files.ls doesn't seem to sort (ignore)
  • rewrite dht get/put tests
  • unskip dht get/put tests in http client
  • dht get accepts string or buffer
  • dht put uses body to send data instead of query string
  • http-client dht get returns a buffer to match core api
  • 'should get the wantlist by peer ID for a different node' test should pass
  • add test for floodsub
  • fix gossipsub test, needs a delay after seeing the peers to be able to delivers msgs to others
  • pubsub publish
    • add undefined msg test
    • ipfs api supports msg in the body
  • pubsub http server tests for data in the body

needs:
ipfs/interop#113

Tracking issue #3030

@aphelionz
Copy link
Contributor

Thanks a lot @hugomrdias. This will be super helpful in getting the next release of OrbitDB out

@aphelionz
Copy link
Contributor

Just checking on this - go-ipfs@0.5.0 seems to be working now. Is this still necessary?

@hugomrdias
Copy link
Member Author

Just checking on this - go-ipfs@0.5.0 seems to be working now. Is this still necessary?

yes

- ipfs.ls remove all options in core api, but keep `long` in http api and cli same as go-ipfs
	- remove sort from the cli and ignore go-ipfs `U` option
	- enable http api mfs tests
- rewrite dht get/put tests
- unskip dht get and put tests in http client
- dht get accepts string or buffer
- dht put uses body to send data instead of query string
- http-client dht get returns a buffer to match core api
- add test for floodsub
- fix gossipsub test, needs a delay after seeing the peers to be able to delivers msgs to others
sort peers to be able to compare
- add undefined msg test
- ipfs api supports msg in the body
@achingbrain achingbrain merged commit 0900bb9 into master Jun 4, 2020
@achingbrain achingbrain deleted the feat/sync-with-go-ipfs-0.5 branch June 4, 2020 13:58
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
New features:

- `ipfs.dht.get` accepts string or buffer
- http-client `ipfs.dht.get` returns a buffer to match core api

Breaking changes:

- ipfs.ls remove all options in core api, but keep `long` in http api and cli same as go-ipfs
  - remove sort from the cli and ignore go-ipfs `U` option
  - enable http api mfs tests
- key.gen defaults, to rsa and 2048
- pin.list only supports streaming responses
- -U argument to `files.ls` has been removed
- dht put uses body to send data instead of query string 

Co-authored-by: Alex Potsides <alex@achingbrain.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants