This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: persist peerstore #3072
Merged
feat: persist peerstore #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the PeerStore persistence by default in the libp2p runtime configurations.
The configuration details can be seen via libp2p/js-libp2p/doc/CONFIGURATION.md#configuring-peerstore. According to the instructions there, we set the browser
thresholdto 1.Regarding benchmarks, I did a small experiment while we do not have testground support to test proper networking scenarios. The conclusions are available in libp2p/js-libp2p#582#issuecomment-637404704. The current results are more significant for node in our current state, but I hope that we can leverage this to also improve browser results with the rendezvous and circuit relay instead of the star servers. It is important pointing out that the results should be better on a real network scenario, since the latencies for connections and exchanging known peers will be bigger than a bunch of nodes in my machine.