feat: add protocol list to ipfs id

[tk26]

addresses issue #3219

[welcome]

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

• The context for this PR is clear, with relevant discussion, decisions
  and stakeholders linked/mentioned.

• Your contribution itself is clear (code comments, self-review for the
  rest) and in its best form. Follow the code contribution
  guidelines
  if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

• A maintainer will triage and assign priority to this PR, commenting on
  any missing things and potentially assigning a reviewer for high
  priority items.

• The PR gets reviews, discussed and approvals as needed.

• The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

[tk26]

I can update the test if the change looks good and makes sense. (was having some issue running the test locally)

[achingbrain]

Thanks for opening this, it looks great.

To get this over the line it needs:

1. Exposing in the HTTP API /id/ endpoint
2. Mapping in the HTTP API Client (this may not be necessary as it looks like the protocols will just come through as a string array)
3. Tests added to the id interface test suite
4. Those tests skipped in the HTTP API Client suite if not implemented in a shipping version of go-ipfs yet

[tk26]

@achingbrain Thanks, done! please let me know how it looks.

[achingbrain]

The PR looks ok but the code doesn't seem to work - that is the protocols array is always empty whether the node is started or not.

@jacobheun @vasco-santos is the peer store the right place to be fetching supported protocols from for the running node?

[achingbrain]

This should assert that there are protocols present, at a minimum I think /ipfs/id/1.0.0 should be supported

[jacobheun]

There should be a handful of protocols, I'd assert them all as they shouldn't change very frequently. There may be differences in Node.js vs browser, depending on modules included, but I think they are currently equivalent.

[tk26]

Got ["/floodsub/1.0.0", "/ipfs/bitswap/1.0.0", "/ipfs/bitswap/1.1.0", "/ipfs/bitswap/1.2.0", "/ipfs/id/1.0.0", "/ipfs/id/push/1.0.0", "/ipfs/ping/1.0.0", "/libp2p/circuit/relay/0.1.0", "/meshsub/1.0.0", "/meshsub/1.1.0"], adding those to the assertions. Thanks guys!

[tk26]

The PR looks ok but the code doesn't seem to work - that is the protocols array is always empty whether the node is started or not.

@jacobheun @vasco-santos is the peer store the right place to be fetching supported protocols from for the running node?

Thanks for checking. AFAIK peerstore seems to be having it (I referenced https://github.com/ipfs/go-ipfs/blob/master/core/commands/id.go#L154)
Also I had tried to run browser-script-tag example project and the protobook API seems to work fine.

[jacobheun]

Self protocols aren't currently stored in the peer store, so they need to be retrieved from the upgrader for now.

Suggested change

	protocols = libp2p.peerStore.protoBook.get(peerId) || []
	protocols = Array.from(libp2p.upgrader.protocols.keys())

[tk26]

Done! Thanks @jacobheun

[jacobheun]

There should be a handful of protocols, I'd assert them all as they shouldn't change very frequently. There may be differences in Node.js vs browser, depending on modules included, but I think they are currently equivalent.

[achingbrain]

Thanks again for submitting this, it'll go out in the next release.

go-ipfs lets you use the id command to fetch metadata about other nodes on the network - would you like to have a go at implementing that for js-ipfs too?

I think you should be able to use the protoBook, addressBook etc on the peerStore to do this, like how you'd originally implemented this PR.

[tk26]

Thanks again for submitting this, it'll go out in the next release.

go-ipfs lets you use the id command to fetch metadata about other nodes on the network - would you like to have a go at implementing that for js-ipfs too?

I think you should be able to use the protoBook, addressBook etc on the peerStore to do this, like how you'd originally implemented this PR.

@achingbrain Thanks for merging this. Sounds interesting, I can take a look at id command for fetching metadata of other nodes.