This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that this was causing incorrect returns when writing the
add
http resource. JS-IPFS-API makes http requests to the js-ipfsobject
core now with the addition of the newadd
support for core here.If the data is a string then the buffer is sent correctly, however if the data field is something else it seems to be wrapping the buffer with some extra maybe new line characters.
@diasdavid @dignifiedquire
Is there a specific reason for the data to be return as a string in the
object/data
http resource?PR 323 Is blocked by this issue.