Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

add dag-jose codec #3299

Closed
wants to merge 2 commits into from
Closed

add dag-jose codec #3299

wants to merge 2 commits into from

Conversation

simonovic86
Copy link
Contributor

@simonovic86 simonovic86 commented Sep 22, 2020

In situation where ipfs-http-client uses dag-jose codec as a format, the IPFS instance cannot respond, since it cannot find the codec even if it's registered on bootstrap of the instance:

{
	ipld: {formats: [dagJoseFormat]}
}

@welcome
Copy link

welcome bot commented Sep 22, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@achingbrain
Copy link
Member

I'm not massively keen on adding more codecs if we can avoid it, I'd rather remove them!

Can you not configure your node to add the dag-jose codec in a similar way to the http client?

Also, where does the source code for dag-jose live? The repo/homepage URLs on https://www.npmjs.com/package/dag-jose are broken.

@simonovic86
Copy link
Contributor Author

simonovic86 commented Sep 22, 2020

I agree. I also realized that I would need to use the multiformats dependency as well.

On the other side, I'm already passing the format as I'm doing in the ipfs-http-client but that format is not being picked up: IpldFormats map is searched without additional options. I assume that's an issue? Am I right? @achingbrain

@achingbrain
Copy link
Member

It should work, could you share an example how you are doing it?

Alternatively add a test that fails to this suite.

@simonovic86
Copy link
Contributor Author

I created a separate ticket for this. The examples are included there.

@simonovic86
Copy link
Contributor Author

no activity on this PR and the codebase has changed. I'm closing the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants