-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
I'm not massively keen on adding more codecs if we can avoid it, I'd rather remove them! Can you not configure your node to add the Also, where does the source code for |
I agree. I also realized that I would need to use the On the other side, I'm already passing the format as I'm doing in the |
It should work, could you share an example how you are doing it? Alternatively add a test that fails to this suite. |
I created a separate ticket for this. The examples are included there. |
no activity on this PR and the codebase has changed. I'm closing the PR. |
In situation where
ipfs-http-client
usesdag-jose
codec as a format, the IPFS instance cannot respond, since it cannot find the codec even if it's registered on bootstrap of the instance: