feat: enable custom formats for server/client DAG (put|get) operations #3309
Conversation
|
CI is failing, could you please take a look? |
|
@achingbrain I've been working on the older branch and didn't merge all the changes. It should be fine now. |
| * @param {object} [opts.ipld.formats] - IPLD custom formats | ||
| * @return {Promise<HttpApi>} | ||
| */ | ||
| async start (opts = {}) { |
There was a problem hiding this comment.
How are the opts passed into daemon start? If I run jsipfs daemon it's not going to pass anything into the start function, so there's no way to set these.
It would be helpful to have a test showing how passing the formats is intended to work, it's not clear to me right now, other than directly using the http server and client.
The updates themselves look good but the usage isn't clear.
There was a problem hiding this comment.
You can't do this through the CLI as it stands, instead you'd create a wrapper that starts a daemon with the required IPLD options.
I've added an example of how to do this in #3347
|
I've tidied up the conflicts and added tests and an example over at #3347 - let's pull this over the line there. |
|
@achingbrain that's awesome! ty! |
ipfs-http-clientfor DAG getipfs-http-serverfor DAG put