Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: add @types/yargs for better inference #3357

Merged
merged 1 commit into from
Oct 28, 2020
Merged

chore: add @types/yargs for better inference #3357

merged 1 commit into from
Oct 28, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Oct 27, 2020

This was prompted by #3353. I am guessing that something end up pulling old version of @types/yargs that was unaware of onFinishCommand. This pull explicitly adds latest @types/yargs into ipfs-cli dev dependencies which:

  1. Seems to be aware of onFinishCommand.
  2. Makes ipfs-cli aware of yargs interface, which without this just appears as any.

@achingbrain achingbrain changed the title feat: add @types/yargs for better inference chore: add @types/yargs for better inference Oct 28, 2020
@achingbrain achingbrain merged commit b07f944 into master Oct 28, 2020
@achingbrain achingbrain deleted the gozala/yargs-types branch October 28, 2020 12:11
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 29, 2021
Open
@rtpro rtpro mentioned this pull request Oct 30, 2022
Open
This was referenced Nov 30, 2023
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
JS IP Board (deprecated)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gozala @achingbrain