This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: align behaviour between go and js for content without paths #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where due to parallel file imports, the reported size of ingested bytes was getting mixed up. We now tally imported bytes against the reported file name instead of assuming a sequential import, taking care to not let the tally grow until memory is exhausted.
Aligns behaviour between js and go when no path is present during an import - we now pass an empty string instead of `'unknown'`.
vasco-santos
approved these changes
Nov 12, 2020
Base automatically changed from
fix/ensure-correct-file-progress-is-reported
to
master
November 12, 2020 12:00
achingbrain
deleted the
fix/align-behaviour-between-go-and-js-for-content-without-paths
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns behaviour between js and go when no path is present during an import
'unknown'.