feat: Add pin.add to ipfs-message-port #3575
Conversation
Updates deps to pull in Buffer@6.x.x Refs #3604
|
👋 Any status update on this? Let me know if I can help. |
@icidasset I'd love to finish this, but had been moved to a team with diff focus making it challenging. That said, I'll be able to spend time on this next week where I'll try to get this to a reviewable state. If you do have time and want to pick it up that would be a great help. |
I'm quite busy too, but I'd say, leave a todo list here, and I'll try to help out whenever I can I guess this goes for #3573 too |
There is no really a list, it was all working locally on my device but seemed to fail on CI figuring out why and getting it green is basically what's remaining (I'm pretty sure it was unrelated to changes here, just was bad timing where tree got red because of some dep version bump). That said I see lot of conflicts now so merging changes from upstream and getting those conflicts resolved would be added piece of work. |
packages/ipfs-core/package.json
Outdated
| @@ -122,6 +122,7 @@ | |||
| "uint8arrays": "^2.1.3" | |||
| }, | |||
| "devDependencies": { | |||
| "libp2p-interfaces": "^0.8.4", | |||
There was a problem hiding this comment.
Otherwise
src/ipns/routing/config.js:26:36 - error TS2345: Argument of type 'import("/Users/gozala/Projects/js-ipfs-2/node_modules/libp2p/node_modules/libp2p-interfaces/dist/src/pubsub/index")' is not assignable to parameter of type 'import("/Users/gozala/Projects/js-ipfs-2/node_modules/libp2p-interfaces/dist/src/pubsub/index")'.
Types of property 'peers' are incompatible.
Type 'Map<string, import("/Users/gozala/Projects/js-ipfs-2/node_modules/libp2p/node_modules/libp2p-interfaces/dist/src/pubsub/peer-streams")>' is not assignable to type 'Map<string, import("/Users/gozala/Projects/js-ipfs-2/node_modules/libp2p-interfaces/dist/src/pubsub/peer-streams")>'.
Type 'import("/Users/gozala/Projects/js-ipfs-2/node_modules/libp2p/node_modules/libp2p-interfaces/dist/src/pubsub/peer-streams")' is not assignable to type 'import("/Users/gozala/Projects/js-ipfs-2/node_modules/libp2p-interfaces/dist/src/pubsub/peer-streams")'.
Types have separate declarations of a private property '_rawOutboundStream'.
26 pubsubDs = new PubsubDatastore(pubsub, localDatastore, peerId)
|
Seems stale? Feel free reopen if still relevant. |
|
It is still relevant and I want to land it, just was unable to resolve all the issues during my rotation and now there are bunch of new conflicts to resolve. |
|
Fission would be happy to take this over, unless there's any objections. We've been maintaining a fork, since we depend on this functionality. It would be nice to have this land in an official release.
@Gozala is there any additional context that we need, or is it mostly about resolving the merge conflicts? |
|
I have updated pr and resolved all the issues, it's ready to be reviewed |
|
Just a friendly follow up! Any movement / anything we can help with? |
|
@expede I don't believe Irakli has bandwidth for this, if you are interested in picking this up and pushing towards the finish line, that would be fantastic 🙏 |
|
@expede @icidasset is this something you'd like to see ship sooner than later? |
|
@lidel Not so urgent since we're not going to do any pinning anymore. Seeing that js-ipfs doesn't do garbage collection anyways. |
|
Closing it for now, if anyone needs |
Builds upon work @icidasset has started in #3497, resolving remaining issues and added refactoring to reuse interfaces.