Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

docs: update browser ipns publish example #3596

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

alensiljak
Copy link
Contributor

@alensiljak alensiljak commented Mar 19, 2021

Applying all the magic from #3584,
updating the dependencies,
adding tips (address example) for working with a local node

@welcome

This comment has been minimized.

@BigLep BigLep added status/ready Ready to be worked need/maintainers-input Needs input from the current maintainer(s) and removed status/ready Ready to be worked labels Mar 22, 2021
@lidel lidel assigned achingbrain and unassigned achingbrain Mar 29, 2021
@lidel lidel added the status/blocked Unable to be worked further until needs are met label Mar 29, 2021
@lidel
Copy link
Member

lidel commented Mar 29, 2021

Blocked until #2945 is done :)

@lidel lidel assigned hugomrdias and unassigned hugomrdias May 17, 2021
@lidel lidel removed the status/blocked Unable to be worked further until needs are met label May 24, 2021
@lidel lidel requested a review from vasco-santos May 24, 2021 14:28
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mistery and apologies for a late review

I have two requests here:

examples/browser-ipns-publish/index.html Outdated Show resolved Hide resolved
examples/browser-ipns-publish/index.html Outdated Show resolved Hide resolved
@lidel lidel added need/author-input Needs input from the original author and removed need/maintainers-input Needs input from the current maintainer(s) labels May 31, 2021
@BigLep BigLep assigned Gozala and unassigned vasco-santos Jun 14, 2021
@BigLep
Copy link
Contributor

BigLep commented Jun 14, 2021

@Gozala : are you able to check to see if this can be merged now?

@vasco-santos
Copy link
Member

@mistery can you please rebase the PR with master as this seems to have a conflict now?

@vasco-santos vasco-santos assigned vasco-santos and unassigned Gozala Jun 22, 2021
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
@alensiljak
Copy link
Contributor Author

Updated!

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @mistery

@oliveriosousa
Copy link
Contributor

Hi @mistery,

Thanks for your improvements, I was having problems connecting using web sockets and this did the trick.

I just want to add one thing, it might be needed to change one line of code:

https://github.com/MisterY/js-ipfs/blob/c70422c07f67401980f10488cd2e8b765b2885b9/examples/browser-ipns-publish/index.js#L58-L73

From this,
ipfsAPI = IpfsHttpClient(url)

To:
ipfsAPI = IpfsHttpClient.create(url)

May be related to an update of ipfs-http-client

@lidel lidel self-assigned this Jul 9, 2021
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting on CI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/author-input Needs input from the original author status/ready Ready to be worked
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants