Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

docs: improve README of browser-create-react-app #3737

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

kvutien
Copy link
Contributor

@kvutien kvutien commented Jul 5, 2021

I found a typo in the last line egt in place of get.

Then I rephrased some sentences. They puzzled me when I read them now from a beginner's point of view (OMG, it's SOO easy to start using jargon prematurely and confuse the reader)

@lidel lidel self-requested a review July 9, 2021 14:46
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for clearing it up. I've made some minor edits but let's get this in.

examples/browser-create-react-app/README.md Outdated Show resolved Hide resolved
examples/browser-create-react-app/README.md Outdated Show resolved Hide resolved
examples/browser-create-react-app/README.md Outdated Show resolved Hide resolved
@achingbrain achingbrain changed the title Some typo corrections to README of browser-create-react-app docs: improve README of browser-create-react-app Jul 27, 2021
@achingbrain achingbrain merged commit 9852d14 into ipfs:master Jul 27, 2021
@kvutien
Copy link
Contributor Author

kvutien commented Jul 27, 2021

Great. Very kind of you.

This is a bit weird, I don't think we refer to a peer id as an "ident" anywhere else.
...

Ah? OK.

Your are right. It was not "ident", but id is used in App.js lines 7-10. I put a question as comments here, BTW. There was something that puzzled me when I tried to understand the code. I don't have the answer and maybe some other learner may have the same question. You may want to change the comments into your explanation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants