This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: return rate in/out as number #3798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type for `rateIn`/`rateOut` should be a float and not an integer. go-IPFS returns a `float64` which isn't representible in js, but we are not interested in that level of accuracy for this value so just return it as a regular `float`. Fixes #3782
achingbrain
changed the title
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
The return type for `rateIn`/`rateOut` should be a number and not an integer. go-IPFS returns a `float64` which isn't representable in js, but we are not interested in that level of accuracy for this value so just return it as a regular `number` which can be a `float`. Fixes #3782 BREAKING CHANGE: rateIn/rateOut are returned as numbers
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type for
rateIn/rateOutshould be a number and not an integer.go-IPFS returns a
float64which isn't representable in js, but we are not interested in that level of accuracy for this value so just return it as a regularnumberwhich can be afloat.Fixes #3782
BREAKING CHANGE: rateIn/rateOut are returned as numbers