Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

docs: update PUBSUB.md #3880

Merged
merged 2 commits into from
Sep 21, 2021
Merged

docs: update PUBSUB.md #3880

merged 2 commits into from
Sep 21, 2021

Conversation

vilgacx
Copy link
Contributor

@vilgacx vilgacx commented Sep 20, 2021

last code wasn't working on line 56. Instead of converting Uint8array to String it was converting the array to string. So instead of text as output , it shows array but with type string. Fixed now with TextDecoder. Working perfectly.

last code wasn't working on line 56. Instead of converting Uint8array to String it was converting the array to string. So instead of text as output , it shows array but with type string. Fixed now with TextDecoder. Working perfectly.
@welcome
Copy link

welcome bot commented Sep 20, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@vilgacx vilgacx changed the title Update PUBSUB.md on line 56. Update PUBSUB.md Sep 20, 2021
@achingbrain achingbrain changed the title Update PUBSUB.md docs: update PUBSUB.md Sep 21, 2021
@achingbrain achingbrain merged commit 4126a5a into ipfs:master Sep 21, 2021
@achingbrain
Copy link
Member

Thanks!

@vilgacx vilgacx deleted the patch-1 branch September 21, 2021 16:53
@vilgacx
Copy link
Contributor Author

vilgacx commented Sep 21, 2021

Thanks!

Your Welcome

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants