This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: do not accept single items for ipfs.add #3900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types allow passing single items to `ipfs.addAll` and multiple items to `ipfs.add`. Instead, only accept single items to `ipfs.add` and streams of item to `ipfs.addAll` and fail with a more helpful error message if you do not do this.
achingbrain
force-pushed
the
fix/do-not-accept-single-items-for-ipfs-add
branch
from
0887fdb to
a86b1be
Compare
This was referenced Dec 13, 2021
This was referenced Jan 24, 2022
This was referenced Mar 18, 2022
This was referenced Mar 29, 2022
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
The types allow passing single items to `ipfs.addAll` and multiple items to `ipfs.add`. Instead, only accept single items to `ipfs.add` and streams of item to `ipfs.addAll` and fail with a more helpful error message if you do not do this. BREAKING CHANGE: errors will now be thrown if multiple items are passed to `ipfs.add` or single items to `ipfs.addAll` (n.b. you can still pass a list of a single item to `ipfs.addAll`)
This was referenced Oct 18, 2022
This was referenced Dec 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types allow passing single items to
ipfs.addAlland multiple itemsto
ipfs.add.Instead, only accept single items to
ipfs.addand streams of item toipfs.addAlland fail with a more helpful error message if you do notdo this.
BREAKING CHANGE: errors will now be thrown if multiple items are passed to
ipfs.addor single items toipfs.addAll(n.b. you can still pass a list of a single item toipfs.addAll)