Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: Add support for dag-jose #3959

Closed
wants to merge 2 commits into from
Closed

feat: Add support for dag-jose #3959

wants to merge 2 commits into from

Conversation

oed
Copy link
Contributor

@oed oed commented Dec 1, 2021

Support for dag-jose was recently merged into go-ipfs ipfs/kubo#8569. This PR adds support for dag-jose in the js-ipfs-http-client so that the new codec in go-ipfs can be used from javascript environments.

A few notes:

  • This is not super urgent as it's easy to plug in additional ipld codecs in javascript. More of a nice to have to be symmetric with go-ipfs
  • Maybe the ipfs-core package should also support dag-jose?

@achingbrain
Copy link
Member

it's easy to plug in additional ipld codecs in javascript

This is very much intentional - there's no need to add extra codecs here which increase the bundle size, install times, etc.

The idea is that if you need a special codec or there's a new release of one or whatever you can configure it yourself without needing to PR this project or wait for a release.

@achingbrain
Copy link
Member

..I say that, but of course go-ipfs is shipping with support for dag-jose by default so js-ipfs will need to do the same thing.

To merge this PR it needs:

  1. support for dag-jose added to ipfs-core - https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-core/src/components/index.js#L290
  2. The version of go-ipfs used in tests upgraded to one that has dag-jose support - https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs/package.json#L87
  3. tests added to the ipfs.dag.get/ipfs.dag.put suites in interface-ipfs-core that exercise the dag-jose support - https://github.com/ipfs/js-ipfs/tree/master/packages/interface-ipfs-core/src/dag

@oed
Copy link
Contributor Author

oed commented Dec 6, 2021

Thanks @achingbrain, will prioritize this!

@stephhuynh18 stephhuynh18 mentioned this pull request Dec 17, 2021
4 tasks
@oed
Copy link
Contributor Author

oed commented Dec 20, 2021

Replaced by #3989, closing.

@oed oed closed this Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants