Use buffer-loader for tests

[fbaiodias]

I implemented a simple buffer-loader based on the binary-loader which fixes the two missing tests.

However I got a weird bug with webpack as it doesn't seem to define Buffer if it is not used outside the tests, so I added an hack on top of the file.
@dignifiedquire do you have any idea how to avoid this?

[daviddias]

@xicombd the buffer thing is weird indeed. Did you tried with the WebPack version that uses node-libs 1.0.0?

[fbaiodias]

Tried with latest webpack and with your fork, and neither seem to work 😟

[dignifiedquire]

@xicombd take a look at this page: http://webpack.github.io/docs/how-to-write-a-loader.html#mark-dependencies you might have to flag Buffer explicitly as a dependency in your loader

[fbaiodias]

@dignifiedquire hum, that doesn't seem to be the problem as it loads the file properly, and I can log the buffer size correctly. The problem is that Buffer isn't defined on the browser context, what makes the two tests that use it fail:

[dignifiedquire]

@xicombd looks like I found a bug in webpack: webpack/webpack#1944

[fbaiodias]

@dignifiedquire Oh, nice catch! That explains it, I'll change my PR to use regular functions in the meanwhile then. Thanks!

[daviddias]

👍 @dignifiedquire :D @xicombd wanna update the PR?

[fbaiodias]

@diasdavid done!

[daviddias]

rad! thank you :)