This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feature object #63
Merged
feature object #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ module.exports = Command.extend({ | |||
|
|
|||
| run: (bool, json, key, value) => { | |||
| if (!key) { | |||
| throw new Error('argument \'key\' is required') | |||
| throw new Error("argument 'key' is required") | |||
There was a problem hiding this comment.
this is standard codestyle things
There was a problem hiding this comment.
maybe lint in a separate commit?
daviddias
force-pushed
the
feature/object
branch
from
860cfd7
to
f90be15
Compare
| @@ -77,7 +77,7 @@ describe('config', () => { | |||
| it('call config with no arguments', done => { | |||
| nexpect.spawn('node', [process.cwd() + '/src/cli/bin.js', 'config']) | |||
| .run((err, stdout, exitcode) => { | |||
| const expected = 'error argument \'key\' is required' | |||
| const expected = "error argument 'key' is required" | |||
There was a problem hiding this comment.
error argument is two words
There was a problem hiding this comment.
interesting, apparently both vim and node understood that there was a tab char there, but github just ignored it, changing to \t:)
daviddias
force-pushed
the
feature/object
branch
from
f90be15
to
33b0f18
Compare
daviddias
force-pushed
the
feature/object
branch
from
33b0f18
to
bf15330
Compare
|
@xicombd @dignifiedquire I'm getting the same "Buffer is not defined" error we were having in test-block.js, but this time, not using arrow functions is not solving the problem, ideas? |
| @@ -18,6 +20,7 @@ function IPFS (repo) { | |||
| repo = defaultRepo() | |||
| } | |||
| const bs = new BlockService(repo) | |||
| const ds = new DAGService(bs) | |||
There was a problem hiding this comment.
ds and bs are really short and hard to distinguish (and understand) :/
There was a problem hiding this comment.
yeah, +1 for explicitly naming them blockService and dagService respectively.
|
@diasdavid some small nitpicks but other than that LGTM |
| @@ -2,10 +2,12 @@ | |||
|
|
|||
| const defaultRepo = require('./default-repo') | |||
| // const bl = require('bl') | |||
There was a problem hiding this comment.
any reason to keep this around?
|
greeeen! :D |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
* chore: dep updated * feat: adds touch and chmod commands and metadata Adds UnixFSv1.5 metadata support to mfs, including displaying it when listing dirs and statting files. Also adds `touch` and `chmod` commands to manipulate metadata in a similar way to the unix shell. * chore: update deps * chore: update deps * test: add cli tests * fix: add missing dep * fix: downgrade repo * fix: fix tests after hashOnly turned to onlyHash * test: add tests for http interface * fix: use multipart pr * chore: remove unecessary browser overrides * chore: update ipfs-utils dep * fix: fix up tests, add support for timespecs * chore: use multipart pr * fix: support optional mtimes
This was referenced Jul 31, 2021
vasco-santos
pushed a commit
that referenced
this pull request
Sep 21, 2021
Bumps [aegir](https://github.com/ipfs/aegir) from 27.0.0 to 28.0.2. - [Release notes](https://github.com/ipfs/aegir/releases) - [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md) - [Commits](ipfs/aegir@v27.0.0...v28.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #58