Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: issue #905 #906

Merged
merged 1 commit into from
Jul 10, 2017
Merged

fix: issue #905 #906

merged 1 commit into from
Jul 10, 2017

Conversation

daviddias
Copy link
Member

@daviddias daviddias commented Jul 10, 2017

@daviddias daviddias added the status/in-progress In progress label Jul 10, 2017
@daviddias daviddias merged commit cbcf90e into master Jul 10, 2017
@daviddias daviddias deleted the fix#905 branch July 10, 2017 09:45
@daviddias daviddias removed the status/in-progress In progress label Jul 10, 2017
dryajov pushed a commit that referenced this pull request Sep 1, 2017
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
The CID version agnostic tests ipfs-inactive/interface-js-ipfs-core#413 identified some functions were not properly serializing CID instances. This PR adds `cleanCID` step to several functions and also updates the `cleanCID` function to not assume buffer CIDs are CIDv0 multihashes.

depends on ipfs-inactive/interface-js-ipfs-core#413


License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

* fix: disable just the rule we're breaking

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

* chore: update dependencies

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

* fix: skip test that go-ipfs cannot pass



License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples/transfer-files doesn't work
1 participant