Adopt next aegir #961

daviddias · 2017-08-26T13:43:35Z

@dignifiedquire went ahead to try js-ipfs with next AEgir but started seeing some strange behaviors and errors. From what I can infer, the new AEgir doesn't like how interface spec tests are loaded by. See errors below:

 FAIL  test/core/interface/interface.spec.js (14.419s)
  ● Console

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50209/ipfs/QmdQiFG5b3myVjxqT3R3kRYgXSNbBdt1uJtss8EQjLAUTC
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50210/ipfs/QmbMQ594mGbkQQD1Qy7tRwCgh3WV97zjRtXymFnUhWzDxp
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50211/ipfs/Qmf8DkFu7mV6ikxUhMYip1yjit9BhUkxmGW63pMPotPgdK
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50212/ipfs/QmWt8bnMs9RCkjCn6qzZM3GXAayQvdCY5VxqBHsPtFzBuc
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50214/ipfs/QmZdcZe4tkgjEhQpvFk3FBdqgDgvqBhP2RTeDUFZL36kmR
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50215/ipfs/QmSh3n1xmFS6ceCgtvXaPZM8Cq49tVocq1sxA9GePUoC3Z
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50216/ipfs/QmdWLvdsHkKehmdfq3dz9UKYW7Xs4xJjcBuTREeyoJ9gir
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50217/ipfs/QmeE7EEgDYyFsZ8SxdxN9STxRQCxvDaY7vuXE4HBiT3izc
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50221/ipfs/QmTo13pEYRiLjq4gc3uATFyEmKiBwXen9vnCqjHk1iDK5p
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50222/ipfs/QmRLZtQthQoXoyvaBYRVPf2SYnQZKasbvw4KWiZFtb1hae
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50223/ipfs/QmNXytQfEuEaLTmvWB45hYXGk23BUjZxwfdPgFMVFJqsJL
    console.log node_modules/interface-ipfs-core/src/pubsub.js:515
      Send/Receive 10k messages took: 3529 ms, 2833 ops / s

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50244/ipfs/QmZijnvw9GoNQCnEWwyqYpRt4MDma8fjjLUTcR9YEPUa6U

  ● interface-ipfs-core tests › .files › encountered a declaration exception

    describe does not expect any arguments

      at Env.describe (node_modules/jest-jasmine2/build/jasmine/Env.js:299:15)
      at Suite.describe (node_modules/interface-ipfs-core/src/files.js:54:5)
      at Object.<anonymous>.module.exports [as files] (node_modules/interface-ipfs-core/src/files.js:20:3)
      at Object.<anonymous> (test/core/interface/files.js:19:6)

 PASS  test/core/create-node.spec.js (21.923s)
  ● Console

    console.log src/core/boot.js:82
      WARNING, trying to set config on uninitialized repo, maybe forgot to set "init: true"
    console.log src/core/boot.js:100
      WARNING, trying to start ipfs node on uninitialized repo, maybe forgot to set "init: true"
    console.log src/core/boot.js:82
      WARNING, trying to set config on uninitialized repo, maybe forgot to set "init: true"
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/9977/ipfs/QmbC8v1wp7aTyJk8aW2S4qtnFcY4KVpM6Y8grwWDSMEwpr

 FAIL  test/core/bitswap.spec.js (28.24s)
  ● Console

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50228/ipfs/QmUDuiRomnQrRW6KRAKRX2RkBwSjoSR1CaGCniL7jVzJNc

See how it is showing logs from PubSub tests and fails on the Files with an exception that is really unexpected: describe does not expect any arguments

Mind checking?

daviddias · 2017-08-26T13:44:06Z

I am in love with the new way of selecting targets and entry points for tests, great job! :D

dignifiedquire · 2017-08-26T22:26:13Z

@diasdavid that error should have been fixed from this: ipfs-inactive/interface-js-ipfs-core#148 might be others around as well. Jest validates things a bit more strict than mocha

daviddias · 2017-08-27T08:25:54Z

Updated and released interface-ipfs-core to 0.31.2

Now seeing other errors:

  ● Console

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58556/ipfs/QmSXfXAtFagKbGp47fytiHtwAPDmDFxShNYLse7kG3gdWY
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58557/ipfs/Qmexof9XeUaocH6QhgXQJCno4JebGZCSbJhpDGwsXQArce
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58558/ipfs/QmYTWEiuGTcKJFuKsXPAA2Ffx35Gt4YykidmvMxQyAFJop
    console.error node_modules/jest-jasmine2/build/jasmine/Env.js:195
      Unhandled error
    console.error node_modules/jest-jasmine2/build/jasmine/Env.js:196
      Error: Unhandled "error" event. (Error: Non-base58 character)
          at Stream.emit (events.js:185:19)
          at next (/Users/imp/code/js-ipfs/node_modules/pull-stream-to-stream/index.js:117:13)
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/throughs/map.js:19:9
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/sources/error.js:5:5
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/throughs/map.js:11:7
          at Immediate.drain [as _onImmediate] (/Users/imp/code/js-ipfs/node_modules/pull-stream-to-stream/index.js:108:5)
          at runCallback (timers.js:781:20)
          at tryOnImmediate (timers.js:743:5)
          at processImmediate [as _immediateCallback] (timers.js:714:5)
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58559/ipfs/QmdGkRje1

and


  ● bitswap › connections › fetches a remote block › 2 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
      at WebSocket.<anonymous> (node_modules/pull-ws/source.js:23:14)
      at WebSocket.onMessage (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:442:14)
      at emitTwo (events.js:125:13)
      at WebSocket.emit (events.js:213:7)
      at Receiver.onbinary (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:848:10)
      at node_modules/pull-ws/node_modules/ws/lib/Receiver.js:628:18
      at Receiver.Object.<anonymous>.Receiver.applyExtensions (node_modules/pull-ws/node_modules/ws/lib/Receiver.js:371:5)

  ● bitswap › connections › fetches a remote block › 3 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
      at WebSocket.<anonymous> (node_modules/pull-ws/source.js:23:14)
      at WebSocket.onMessage (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:442:14)
      at emitTwo (events.js:125:13)
      at WebSocket.emit (events.js:213:7)
      at Receiver.onbinary (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:848:10)
      at node_modules/pull-ws/node_modules/ws/lib/Receiver.js:628:18
      at Receiver.Object.<anonymous>.Receiver.applyExtensions (node_modules/pull-ws/node_modules/ws/lib/Receiver.js:371:5)

  ● bitswap › connections › fetches a remote file › 2 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7

daviddias · 2017-08-27T08:30:24Z

✅ Browser tests are working fine in isolation

dignifiedquire · 2017-08-28T23:09:54Z

maybe try no-parallel?

dignifiedquire · 2017-08-29T12:19:00Z

@diasdavid looking at these failures, they don't look related to aegir to me, rather than other things are actually broken

daviddias · 2017-08-29T12:44:33Z

Hm.. it might be that due to the new aegir, some things need to change, however, the tests do pass with old aegir. This is also happening with ipfs-inactive/js-ipfs-http-client#585 and even in the aegir-test-repo ipfs-inactive/aegir-test-repo#1 (comment) which suggests that it was not properly tested before the 12.0.0 release.

Let's figure out first in aegir test repo, then js-ipfs-api (which is very close) and then here. Probably fixing for one will fix for all anyway :)

dignifiedquire · 2017-08-29T13:04:58Z

This might also indicate that some things were not being properly tested before and we have actual failures in these cases

dignifiedquire · 2017-09-04T13:16:29Z

fix for Buffer issue is here: https://github.com/pull-stream/pull-ws/pull/20/files

daviddias · 2017-09-05T15:07:35Z

package.json

@@ -26,7 +26,7 @@
    "release-minor": "aegir release --type minor --no-parallel",
    "release-major": "aegir release --type major --no-parallel",
    "test": "aegir test --no-parallel --timeout 50000",
-    "test:node": "aegir test --target node --no-parallel",
+    "test:node": "aegir test --target node --no-parallel --timeout 50000",


I really prefer to see these timeouts in tests. It will help us target batch by batch and do improvs across the board :)

feel free, but I don't think it is that useful compared to the amount of time it costs to increase timeouts in each tests manually

(and how often that is breaking)

dignifiedquire · 2017-09-05T15:11:41Z

Tests started working on circle now, due to the changes in the libp2p modules some hashes changed, (dag node protobuf orders the bytes a bit different now), but those fixes should be done independently

dignifiedquire · 2017-09-05T15:15:56Z

ref: protobufjs/protobuf.js#908

wip

d851c2e

daviddias requested a review from dignifiedquire August 26, 2017 13:43

chore: update interface-ipfs-core

31c20a5

fix npm scripts

51c7bad

daviddias mentioned this pull request Aug 28, 2017

Bootstrapers tests, for @lgierth #899

Merged

test: --no-parallel

a07ff60

daviddias mentioned this pull request Sep 4, 2017

⚡️ v0.26.0 RELEASE 🚀 #986

Closed

16 tasks

dignifiedquire added 4 commits September 4, 2017 13:45

Merge remote-tracking branch 'origin/master' into feat/next-aegir

597fc73

fixes for merge with master

f50c89b

move coverage to circle

f97e01c

more timeouts

8c19b5e

dignifiedquire added 2 commits September 5, 2017 16:26

bump versions

5900d7c

more default timeouts

0c0e325

daviddias commented Sep 5, 2017

View reviewed changes

Merge remote-tracking branch 'origin/master' into feat/next-aegir

995fed4

daviddias changed the base branch from master to feat/aegir-next-2 September 8, 2017 05:17

daviddias merged commit bffd1e5 into feat/aegir-next-2 Sep 8, 2017

daviddias deleted the feat/next-aegir branch September 8, 2017 05:18

snyk-bot mentioned this pull request Oct 22, 2022

[Snyk] Security upgrade aegir from 36.2.3 to 37.1.1 devcode1981/js-ipfs#13

Open

internetbuilder mentioned this pull request Feb 11, 2024

[Snyk] Security upgrade aegir from 34.1.0 to 37.1.1 internetbuilder/js-ipfs#119

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adopt next aegir #961

Adopt next aegir #961

daviddias commented Aug 26, 2017

daviddias commented Aug 26, 2017

dignifiedquire commented Aug 26, 2017

daviddias commented Aug 27, 2017

daviddias commented Aug 27, 2017

dignifiedquire commented Aug 28, 2017

dignifiedquire commented Aug 29, 2017

daviddias commented Aug 29, 2017

dignifiedquire commented Aug 29, 2017

dignifiedquire commented Sep 4, 2017

daviddias Sep 5, 2017

dignifiedquire Sep 5, 2017

dignifiedquire Sep 5, 2017

dignifiedquire commented Sep 5, 2017

dignifiedquire commented Sep 5, 2017

Adopt next aegir #961

Adopt next aegir #961

Conversation

daviddias commented Aug 26, 2017

daviddias commented Aug 26, 2017

dignifiedquire commented Aug 26, 2017

daviddias commented Aug 27, 2017

daviddias commented Aug 27, 2017

dignifiedquire commented Aug 28, 2017

dignifiedquire commented Aug 29, 2017

daviddias commented Aug 29, 2017

dignifiedquire commented Aug 29, 2017

dignifiedquire commented Sep 4, 2017

daviddias Sep 5, 2017

Choose a reason for hiding this comment

dignifiedquire Sep 5, 2017

Choose a reason for hiding this comment

dignifiedquire Sep 5, 2017

Choose a reason for hiding this comment

dignifiedquire commented Sep 5, 2017

dignifiedquire commented Sep 5, 2017