Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to trap JSON.parse and emit more informative error on parse failure #721

Closed
SgtPooki opened this issue Mar 3, 2022 · 1 comment · Fixed by #722
Closed

Need to trap JSON.parse and emit more informative error on parse failure #721

SgtPooki opened this issue Mar 3, 2022 · 1 comment · Fixed by #722
Labels
released status/in-progress In progress

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Mar 3, 2022

ipfs/ipfs-desktop#2004 and ipfs/ipfs-desktop#2000 show that a JSON parse error happened, which points to

js-ipfsd-ctl/src/ipfsd-daemon.js

Line 366 in 70dff97

return JSON.parse(stdout)

we should wrap the json.parse in a try/catch and provide a more informative error message:

  1. What is the value of stdout
  2. What is the value of key
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Mar 3, 2022
@lidel lidel mentioned this issue Mar 3, 2022
Closed
lidel added a commit that referenced this issue Mar 14, 2022
@lidel
fix: pass ipfs config show errors
574c092 
Closes #721
@lidel lidel mentioned this issue Mar 14, 2022
Merged
@lidel lidel removed the need/triage Needs initial labeling and prioritization label Apr 8, 2022
@lidel lidel added the status/in-progress In progress label Apr 22, 2022
SgtPooki added a commit that referenced this issue Oct 19, 2022
@lidel @SgtPooki
fix: pass ipfs config show errors (#722)
efb2779 
* fix: pass ipfs config show errors

Closes #721

* fix: resolve type errors in ipfsd-daemon

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Oct 19, 2022
@semantic-release-bot
chore(release): 12.2.2 [skip ci]
2323bed 
## [12.2.2](v12.2.1...v12.2.2) (2022-10-19)

### Bug Fixes

* pass ipfs config show errors ([#722](#722)) ([efb2779](efb2779)), closes [#721](#721)
@github-actions
Copy link

🎉 This issue has been resolved in version 12.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass ipfs config show errors ipfs/js-ipfsd-ctl
2 participants
@lidel @SgtPooki