Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: treat validity as opaque #307

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix!: treat validity as opaque #307

merged 1 commit into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. fix!: treat validity as opaque 

    Instead of parsing the validity field of an IPNS record as a timestamp
during unmarshalling, treat it as an opaque string value.

This ensures we can round-trip records supplied by other systems which
may have a different interpretation of rfc3339 dates, for example.

It also means we can handle different types of validity types, not
just EOL.

BREAKING CHANGE: the validity field is now a string
    @achingbrain
    achingbrain committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    fa76028 View commit details
    Browse the repository at this point in the history