feat: Re-enable interface tests and get them succeeding

.aegir.js

@@ -1,19 +1,29 @@
 import { createServer } from 'ipfsd-ctl'
-import getPort from 'aegir/get-port'
 import EchoServer from 'aegir/echo-server'
 
+/**
+ * @typedef {object} BeforeType
+ * @property {import('ipfsd-ctl').Controller} server
+ * @property {EchoServer} echoServer
+ * @property {typeof import('./test/utils/mock-pinning-service.js')} pinningService
+ * @property {Record<string, string>} env
+ */
 /** @type {import('aegir').PartialOptions} */
 export default {
   build: {
     bundlesizeMax: '66KB'
   },
   test: {
     bail: false,
+    /**
+     *
+     * @param {Parameters<import('aegir').Options['test']['before']>[0]} options
+     * @returns {Promise<BeforeType>}
+     */
     async before (options) {
       const { PinningService } = await import('./test/utils/mock-pinning-service.js')
       const pinningService = await PinningService.start()
       const server = createServer({
-        host: '127.0.0.1',
         port: 0
       }, {
         type: 'go',
@@ -25,13 +35,18 @@ export default {
       await echoServer.start()
 
       await server.start()
+      /**
+       * @type {BeforeType}
+       */
       return {
         server,
         echoServer,
         pinningService,
         env: {
+          NODE_OPTIONS: '--no-experimental-fetch',
           IPFSD_SERVER: `http://${server.host}:${server.server.info.port}`,
           PINNING_SERVICE_ENDPOINT: pinningService.endpoint,
+          PINNING_SERVICE_KEY: 'secret',
           ECHO_SERVER: `http://${echoServer.host}:${echoServer.port}`,
         }
       }

.eslintrc.json

@@ -1,6 +1,12 @@
 
 {
+  "plugins": [
+    "jsdoc",
+    "mocha"
+  ],
   "extends": [
+    "plugin:jsdoc/recommended",
+    "plugin:mocha/recommended",
     "ipfs"
   ],
   "env": {
@@ -14,7 +20,20 @@
   "rules": {
     "no-return-await": "off",
     "no-undef-init": "off",
-    "no-warning-comments": "off"
+    "no-warning-comments": "off",
+    "mocha/max-top-level-suites": "off",
+    "mocha/no-setup-in-describe": "off"
   },
-  "ignorePatterns": [ "gists/", "vendor/", "test/fixtures/", "test/interface-tests/fixtures/"]
+  "ignorePatterns": [ "gists/", "vendor/", "test/fixtures/", "test/interface-tests/fixtures/"],
+  "overrides": [
+    {
+      "files": ["./test/interface-tests/src/**"],
+      "rules": {
+        "mocha/no-exports": "off",
+        "mocha/max-top-level-suites": "off",
+        "mocha/no-sibling-hooks": "warn",
+        "mocha/no-setup-in-describe": "off"
+      }
+    }
+  ]
 }

.github/workflows/js-test-and-release.yml

@@ -27,74 +27,35 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest, ubuntu-latest, macos-latest]
-        node: [16]
-      fail-fast: true
+      fail-fast: false
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: ${{ matrix.node }}
+          node-version: lts/*
       - uses: ipfs/aegir/actions/cache-node-modules@master
       - run: npm run --if-present test:node
       - uses: codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378 # v3.1.0
         with:
           flags: node
 
-  test-chrome:
-    needs: check
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
-        with:
-          node-version: lts/*
-      - uses: ipfs/aegir/actions/cache-node-modules@master
-      - run: npm run --if-present test:chrome
-      - uses: codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378 # v3.1.0
-        with:
-          flags: chrome
-
-  test-chrome-webworker:
-    needs: check
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
-        with:
-          node-version: lts/*
-      - uses: ipfs/aegir/actions/cache-node-modules@master
-      - run: npm run --if-present test:chrome-webworker
-      - uses: codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378 # v3.1.0
-        with:
-          flags: chrome-webworker
-
-  test-firefox:
-    needs: check
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
-        with:
-          node-version: lts/*
-      - uses: ipfs/aegir/actions/cache-node-modules@master
-      - run: npm run --if-present test:firefox
-      - uses: codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378 # v3.1.0
-        with:
-          flags: firefox
-
-  test-firefox-webworker:
+  test-non-node-target:
     needs: check
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        target: [chrome, chrome-webworker, firefox, firefox-webworker]
+      fail-fast: false
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
           node-version: lts/*
       - uses: ipfs/aegir/actions/cache-node-modules@master
-      - run: npm run --if-present test:firefox-webworker
+      - run: npm run --if-present test:${{ matrix.target }} -- --bail=false
       - uses: codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378 # v3.1.0
         with:
-          flags: firefox-webworker
+          flags: ${{ matrix.target }}
 
   test-electron-main:
     needs: check
@@ -125,7 +86,7 @@ jobs:
           flags: electron-renderer
 
   release:
-    needs: [test-node, test-chrome, test-chrome-webworker, test-firefox, test-firefox-webworker, test-electron-main, test-electron-renderer]
+    needs: [test-node, test-non-node-target, test-electron-main, test-electron-renderer]
     runs-on: ubuntu-latest
     if: github.event_name == 'push' && github.ref == 'refs/heads/master' # with #262 - 'refs/heads/${{{ github.default_branch }}}'
     steps: