fix(blockstore-fs): allow non sha-256 multihashes #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multihashes aren't CID's thus decode fails when not using a
sha-256
mutlihash.It currently works fine with
sha-256
(code 18) multihashes as 18 is the prefix to CIDv0 thus the decode works ok.The
CID.decode
here https://github.com/ipfs/js-stores/blob/main/packages/blockstore-fs/src/sharding.ts#L64 eventually callsinspectBytes
https://github.com/multiformats/js-multiformats/blob/master/src/cid.ts#L345 which fails.Proposed fix is to use
CID.bytes
instead ofCID.multihash.bytes
.Potentially a breaking change as any current files won't be accessible.