Remove duplicate Transfer-Encoding header

License: MIT Signed-off-by: rht <rhtbot@gmail.com>
ipfs · Jan 21, 2016 · 73b4985 · 73b4985
1 parent 89a6f01
commit 73b4985
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/commands/http/handler.go b/commands/http/handler.go
@@ -255,7 +255,6 @@ func sendResponse(w http.ResponseWriter, r *http.Request, res cmds.Response, req
  }
 
  h.Set(contentTypeHeader, mime)
- h.Set(transferEncodingHeader, "chunked")
 
  // set 'allowed' headers
  h.Set("Access-Control-Allow-Headers", "X-Stream-Output, X-Chunked-Output")

diff --git a/test/sharness/t0060-daemon.sh b/test/sharness/t0060-daemon.sh
@@ -36,6 +36,12 @@ test_expect_success "'ipfs config Identity.PeerID' works" '
  PEERID=$(ipfs config Identity.PeerID)
 '
 
+# see https://github.com/ipfs/go-ipfs/issues/2190
+test_expect_success "test for duplicate Transfer-Encoding Header" '
+ curl -v -i http://localhost:5001/api/v0/version 2> curl_output &&
+ test $(grep -c "Transfer-Encoding" curl_output) -eq 1
+'
+
 test_expect_success "'ipfs swarm addrs local' works" '
  ipfs swarm addrs local >local_addrs
 '