Skip to content

Commit

Permalink
Add patch too
Browse files Browse the repository at this point in the history 
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
  • Loading branch information
@whyrusleeping
whyrusleeping committed Dec 13, 2015
1 parent f3f3d5c commit bfff3fa
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions core/commands/root.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ var rootROSubcommands = map[string]*cmds.Command{
"links": objectLinksCmd,
"get": objectGetCmd,
"stat": objectStatCmd,
"patch": objectPatchCmd,

This comment has been minimized.

Sign in to view

Copy link
@rht

rht Jan 25, 2016

Contributor

@whyrusleeping why is this allowed?

This comment has been minimized.

Sign in to view

Copy link
@whyrusleeping

whyrusleeping Jan 26, 2016

Author Member

uhm... i don't remember my original logic for this. It might have had something to do with gx though (although gx only uses patch for publish, which also requires add so i don't think thats it.)

This comment has been minimized.

Sign in to view

Copy link
@rht

rht Jan 27, 2016

Contributor

This hole is too big. One compromise is to make it smaller by allowing only ipfs object patch add-link. But then, it doesn't make sense to open this hole just for gx use case, while leaving the rest of ro api user with the hole.

(Do you have time this week to help me out to speed up the splitting of go-ipfs? go-libp2p, ipfswatch, gateway, and the files interface. It shouldn't take that long.)

e: (somehow I missed libp2p)
},
},
"refs": RefsROCmd,
Expand Down

0 comments on commit bfff3fa

Please sign in to comment.