Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs bitswap stat fails in an ugly way when offline #1236

Closed
whyrusleeping opened this issue May 16, 2015 · 4 comments
Closed

ipfs bitswap stat fails in an ugly way when offline #1236

whyrusleeping opened this issue May 16, 2015 · 4 comments
Labels
topic/bitswap Topic bitswap

Comments

@whyrusleeping
Copy link
Member

ipfs bitswap stat should print out a message like "this command must be run in online mode" when run without a daemon, instead we get an ugly casting error.
@whyrusleeping whyrusleeping mentioned this issue May 22, 2015
Merged
@daviddias daviddias added the topic/bitswap Topic bitswap label Jan 2, 2016
@jbenet
Copy link
Member

jbenet commented Jan 13, 2016

Is there a test for this?
On Fri, Jan 1, 2016 at 22:40 Jeromy Johnson notifications@github.com
wrote:

Closed #1236 #1236.

—
Reply to this email directly or view it on GitHub
#1236 (comment).

@Ape
Copy link

Ape commented Jan 13, 2016

@jbenet See #1278.

@jbenet
Copy link
Member

jbenet commented Jan 13, 2016

it should have a test case, that verifies ipfs bitswap stat and friends do not fail in an ugly way when offline.

@RichardLitt
Copy link
Member

Should I open an issue for that test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/bitswap Topic bitswap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jbenet @Ape @RichardLitt @daviddias @whyrusleeping