-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version check in/after handshake #166
Labels
help wanted
Seeking public contribution on this issue
Comments
Closed
Should reference issue #161 for this. |
Merged
Addressed in #180. |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this issue
Oct 23, 2021
fix dht client bugs
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this issue
Feb 25, 2022
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this issue
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right after the secure channel handshake, ipfs connections should handshake protocol versions. Incompatible versions should not talk to each other.
I think the right way is to:
*(it's possible to use per-service versions, but ipfs is not large enough / network alive enough to warrant that yet, we can revisit then)
note on semver major number
For those unfamiliar with semver, don't think of a semver
<major> = 2
asipfs protocol v2
. It's reallyipfs protocol 1.<major>.<minor>.<patch>
in that a 2.x.x.x IMO means a massive rethinking. (thinkipv4 -> ipv6
)The text was updated successfully, but these errors were encountered: