Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic in bitswap TestSendToWantingPeer #217

Closed
jbenet opened this issue Oct 27, 2014 · 3 comments · Fixed by #222
Closed

panic in bitswap TestSendToWantingPeer #217

jbenet opened this issue Oct 27, 2014 · 3 comments · Fixed by #222
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@jbenet
Copy link
Member

jbenet commented Oct 27, 2014

https://travis-ci.org/jbenet/go-ipfs/jobs/39183561

=== RUN TestSendToWantingPeer
--- FAIL: TestSendToWantingPeer (0.03 seconds)
    bitswap_test.go:163: Session %!v(PANIC=runtime error: slice bounds out of range)
    bitswap_test.go:164: Session %!v(PANIC=runtime error: slice bounds out of range)
    bitswap_test.go:165: Session %!v(PANIC=runtime error: slice bounds out of range)
    bitswap_test.go:171: Peer %!v(PANIC=runtime error: slice bounds out of range) attempts to get QmTTA2daxGqo5denp6SwLzzkLJm3fuisYEi9CoWsuHpzfb. NB: not available
    bitswap_test.go:179: Peer %!v(PANIC=runtime error: slice bounds out of range) announes availability  of Qmd8VJwP745eE5xsmvbW56ZuAoQvXDhrZ9evpkNBk5eXiV
    bitswap_test.go:186: %!v(PANIC=runtime error: slice bounds out of range) gets Qmd8VJwP745eE5xsmvbW56ZuAoQvXDhrZ9evpkNBk5eXiV from %!v(PANIC=runtime error: slice bounds out of range) and discovers it wants QmTTA2daxGqo5denp6SwLzzkLJm3fuisYEi9CoWsuHpzfb
    bitswap_test.go:189: context deadline exceeded
FAIL
FAIL    github.com/jbenet/go-ipfs/exchange/bitswap  2.837s
@jbenet jbenet changed the title panic in bitswap: panic in bitswap TestSendToWantingPeer Oct 27, 2014
@jbenet jbenet added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue labels Oct 27, 2014
@btc btc self-assigned this Oct 28, 2014
@btc btc removed the help wanted Seeking public contribution on this issue label Oct 28, 2014
@btc btc mentioned this issue Oct 28, 2014
Merged
@btc
Copy link
Contributor

btc commented Oct 28, 2014

The panic shown here

    bitswap_test.go:163: Session %!v(PANIC=runtime error: slice bounds out of range)

is caused by this line

t.Logf("Session %v\n", me.peer)

when the peer's String() method is called (and peer was instantiated using WithId)

Fixed in #222

@btc btc added the ready label Oct 28, 2014
@jbenet
Copy link
Member Author

jbenet commented Nov 4, 2014

Still broken. https://travis-ci.org/jbenet/go-ipfs/jobs/39928329

@jbenet
Copy link
Member Author

jbenet commented Nov 4, 2014

(we know it is, just noticing certain builds fail cause of it)

@btc btc closed this as completed in #222 Nov 16, 2014
@btc btc removed the ready label Nov 16, 2014
@jbenet jbenet unassigned btc Mar 30, 2015
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@qizheng09 @anacrolix
add RoutingTable func (ipfs#217)
9d60a68 
* add RoutingTable func

* fix gofmt
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(peer) String() bounds check ipfs/kubo
2 participants
@jbenet @btc