Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs init fails with no stdin #2748

Closed
whyrusleeping opened this issue May 19, 2016 · 7 comments · Fixed by #2822
Closed

ipfs init fails with no stdin #2748

whyrusleeping opened this issue May 19, 2016 · 7 comments · Fixed by #2822
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
ipfs-0.4.3-rc1

Comments

@whyrusleeping
Copy link
Member

whyrusleeping commented May 19, 2016 •
edited
Loading

echo "" | ipfs init reproduces the issue. This is a problem if i want to run ipfs init in a docker container. (although passing -t is a workaround)
@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label May 19, 2016
@whyrusleeping
Copy link
Member Author

This appears to be a problem with most commands actually

@ghost
Copy link

ghost commented May 19, 2016

Likely introduced in #2581, we fixed a similar thing in #1263.

@Kubuxu
Copy link
Member

Kubuxu commented May 19, 2016

I can look into fixing it tomorrow.

ghost pushed a commit that referenced this issue May 19, 2016
Revert "Implements repository initialization with default config"
3ee13c7 
See #2748

This reverts commit 6989686.

License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@ghost ghost mentioned this issue May 19, 2016
Merged
ghost pushed a commit that referenced this issue May 19, 2016
Revert "Implements repository initialization with default config"
f1fad21 
See #2748

This reverts commit 6989686.

License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost pushed a commit that referenced this issue May 19, 2016
Revert "Implements repository initialization with default config"
77ef391 
See #2748

This reverts commit 6989686.

License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@Kubuxu
Copy link
Member

Kubuxu commented May 20, 2016

Resolved in #2749

@Kubuxu Kubuxu closed this as completed May 20, 2016
@ghost
Copy link

ghost commented May 20, 2016

Well this hasn't exactly been resolved... we just reverted the commit.

@ghost ghost reopened this May 20, 2016
@ghost ghost mentioned this issue May 28, 2016
Closed
@dignifiedquire
Copy link
Member

This is a real problem for us, ipfsd-ctl the module to control a go daemon from node.js is not able to work with 0.4.2 because of this bug.

@dignifiedquire dignifiedquire mentioned this issue Jun 3, 2016
Merged
@ghost
Copy link

ghost commented Jun 3, 2016

hey @sivachandran, would be great to get this fixed for 0.4.3!

This was referenced Jun 4, 2016
Closed
Merged
@Kubuxu Kubuxu self-assigned this Jun 7, 2016
@whyrusleeping whyrusleeping mentioned this issue Jun 13, 2016
Closed
@whyrusleeping whyrusleeping added this to the Ipfs 0.4.3 milestone Jun 21, 2016
@JGAntunes JGAntunes mentioned this issue Jul 13, 2016
Closed
This was referenced Jul 15, 2016
Merged
Merged
@Kubuxu Kubuxu removed their assignment Aug 26, 2016
@rcurrie rcurrie mentioned this issue Aug 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
ipfs-0.4.3-rc1
Development

Successfully merging a pull request may close this issue.

Change logic of stdin input to be last and only if required ipfs/kubo
3 participants
@dignifiedquire @whyrusleeping @Kubuxu